Files

31 lines
3.9 KiB
Markdown
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# AeroSim lessons review — general
## Evidence boundary
Source repository: [corp-v1-aerosim-skills-code-agent/channel-general-skic-aerosim](https://gitea.lego-cloud.eu/corp-v1-aerosim-skills-code-agent/channel-general-skic-aerosim)
Source commit: `f97a4e8bbc1e107ddff0fac02a6730a32afed56e` (branch `test`, pinned clone; not the earlier adoption-base SHA).
Central baseline: `e291ea3af85f7656d9293fad510c217ca495df0f`. Reviewed the full source package: `SKILL.md`, `ADOPTION.md`, and `references/shared-coordination-pr-refresh.md`. All existing source reference files were byte-identical to central at baseline; changes below address omissions or contradictions, not wholesale copying.
The installed `channel-general-skic-aerosim/SKILL.md` was also compared read-only. Runtime SHA-256: `5944a1ba8198f90bca29c186bec8dc173bac006c7cf412dedce9ae0eda53ef58`. Runtime differs from the pinned repository and has no verified source commit for its local-only changes; it is observation, not remote or Board approval evidence. This delegated review did not change any installed package or AeroSim/other project copy. The coordinating session owns authorized central publication and central runtime refresh.
Review authority: Board-owner request message `1562171939961966693` authorizes central reference improvement and remote publication; the coordinating session also owns the authorized central runtime refresh. Central source publication must be verified before refreshing its installed package. No project adoption, project permission/authority expansion or naming migration is authorized.
## Adopted lessons
- `SKILL.md` → **Synchronization Workflow**, steps 6–12 (especially 11–12), and `references/shared-coordination-pr-refresh.md` → **6. Close the channel-activity race** / **7. Scheduled-delivery boundary**: make the existing reference's final convergence and single-delivery checks explicit at the point of execution. Polling watermarks are not substantive evidence. Material late changes require reconciliation, not a stale success report.
- `SKILL.md` → **Overview**, **Pending ownership and governance corrections**, and **Kanban Handoff**: preserve domain ownership. Remove the central General copy of Scope navigation/table rules and approval-shaped delivery vocabulary; the pinned central Scope contract already has a different hierarchy and separates gates from delivery. This is conflict removal, not adoption of AeroSim's navigation.
## Exclusions
No roster/contact data, named owner assignments, standing merge delegation, blocker-execution authority, board migration, project-local topology overrides or scheduler authorization is imported. Runtime-only **Current AeroSim human roster and work emails — skill-only record**, **Hermes owns blocker resolution**, and **Standing AeroSim PR merge authority** were inspected but not adopted or reproduced. Runtime also differs in board routing and UAT wording; neither is proof of central policy. Existing central bootstrap stop conditions and human gates remain intact.
## Central topology authority
The coordinating review record `GUILD-IMP-20261020-aerosim-reference-lessons` confirms central-only maintenance. `channel-board-skic` v4.5.0, **Board Authority** / **Naming Model** / **Hermes access and Corp project automation policy**, records Board message `1552966246591365123` approving eight lifecycle channels, with UAT between Delivery and Releases. Align ordinary synchronization and references to that existing policy. Historical seven-channel bootstrap overrides are not widened; only separately reauthorized overrides may add UAT. Runtime seven-channel wording is stale, not promoted authority.
## Verification
Run `python3 -B -m unittest discover -s tests -v` from this repository and `git diff --check`. Tests validate normative documentation contracts and linked files offline; they do not claim live workflow, CI, deployment or remote publication verification.