Files
channel-scope-skic/references/aerosim-lessons-review.md
T

4.7 KiB

AeroSim lessons review — scope

Evidence boundary

Source repository: corp-v1-aerosim-skills-code-agent/corp-v1-channel-scope-aerosim

Source commit: 3eb7a2a530d63e4ad20f7bff36cf435dc98eb7d6 (branch test, pinned clone; not the earlier adoption-base SHA).

Central baseline: 602b1a0afdac56f4b8a10def4bd241b53495c3e3. Reviewed the full source package: SKILL.md, ADOPTION.md, and references/data-backed-scope-integrity.md, references/decision-readiness.md, references/feature-set-completeness.md, references/react-flow-governed-state.md, references/roadmap-multidimensional-state.md. All existing source reference files were byte-identical to central at baseline; changes below address omissions or contradictions, not wholesale copying.

The installed corp-v1-channel-scope-aerosim/SKILL.md was also compared read-only. Runtime SHA-256: 78d2e5c1a192184cf2edd6d056182631297a9f1cb97e18cffbc402399c215b47. Runtime differs from the pinned repository and has no verified source commit for its local-only changes; it is observation, not remote or Board approval evidence. This delegated review did not change any installed package or AeroSim/other project copy. The coordinating session owns authorized central publication and central runtime refresh.

Review authority: Board-owner request message 1562171939961966693 authorizes central reference improvement and remote publication; the coordinating session also owns the authorized central runtime refresh. Central source publication must be verified before refreshing its installed package. No project adoption, project permission/authority expansion or naming migration is authorized.

Adopted lessons

  • SKILL.md → Proactive Iteration Requirement, acceptance-gap paragraphs: distinguish observed outcomes from missing evidence; bind exhaustive coverage to Scope and tested-application revisions; never transfer observations to newer source or manufacture retroactive approval. Existing references/data-backed-scope-integrity.md → Reproducible acceptance-evidence packet consistency remains the detailed contract.
  • SKILL.md → Synchronization Workflow, step 8 and its review-ledger, temporal-consistency and continuation bullets; step 9: review the complete candidate with a dynamic claim ledger, invalidate review after base drift, distinguish a login-page HTTP 200 from deployed-content verification. Retain central independent review, not AeroSim self-review substitution. Resolve central early-push wording against the existing pre-publication migration review gate.
  • SKILL.md → Overview (under Documentation Contract), Roadmap, and React Flow visualization contract: use plain-language Status basis rather than internal EXACT/DERIVED reader labels, matching the already-shared roadmap reference.
  • SKILL.md → Epics, Features, and Tasks forbids duplicate completeness sections, while Human Decision Readiness and references/feature-set-completeness.md still prescribe them. Resolve the central contradiction by retaining the review mechanics in a linked governed review artifact, not restoring forbidden reader sections or a global Question bucket.

Exclusions

No Jira mandate, API recovery operations, release-instance migration, cumulative release schema, named owners, org-wide PR sweep, standing merge authority, self-review downgrade, dispatcher path/credentials or additional channel authorization is adopted. Runtime-only Documentation Contract changes to a release-first sidebar were inspected and excluded; runtime also has seven/eight-channel and UAT-route inconsistencies. Central navigation, stable identities, human decisions and independent review remain authoritative. No release-first adoption or naming migration is authorized by this review.

Central topology authority

The coordinating review record GUILD-IMP-20261020-aerosim-reference-lessons confirms central-only maintenance. corp-v1-main v4.5.0, Board Authority / Naming Model / Hermes access and Corp project automation policy, records Board message 1552966246591365123 approving eight lifecycle channels, with UAT between Delivery and Releases. Align ordinary synchronization and references to that existing policy. Historical seven-channel bootstrap overrides are not widened; only separately reauthorized overrides may add UAT. Runtime seven-channel wording is stale, not promoted authority.

Verification

Run python3 -B -m unittest discover -s tests -v from this repository and git diff --check. Tests validate normative documentation contracts and linked files offline; they do not claim live workflow, CI, deployment or remote publication verification.