docs: promote reusable AeroSim channel lessons

This commit is contained in:
jarvis-at-skic committed 2026-10-20 18:42:41 +00:00
1 parent 2844c4a5f7
commit 4a7c9bfcf7
4 files changed
+111 -14

No files matched your search

+29
View File
@@ -0,0 +1,29 @@
# AeroSim lessons review — Releases
## Immutable sources
AeroSim Releases source SHA: `3c4b4788915bae3d89303959c46a8854c9a141bc`. Central baseline: `2844c4a5f7231ab597519a59f5f11cfe1c858b9f`.
- [SKILL.md](https://gitea.lego-cloud.eu/corp-v1-aerosim-skills-code-agent/corp-v1-channel-releases-aerosim/src/commit/3c4b4788915bae3d89303959c46a8854c9a141bc/SKILL.md)
- [references/recurring-readiness-pr-refresh.md](https://gitea.lego-cloud.eu/corp-v1-aerosim-skills-code-agent/corp-v1-channel-releases-aerosim/src/commit/3c4b4788915bae3d89303959c46a8854c9a141bc/references/recurring-readiness-pr-refresh.md)
Read the full source skill and readiness reference against their central counterparts. Relevant sections: **Release Readiness**, **Gate 1 — explicit request**, **UAT promotion gate**, **Release Completion Gate**, and **Synchronization Workflow**.
## Promoted lessons
- Consume a complete, exact-tuple UAT pass independently of release authorization. Record a separate production desired-state revision and verify it live rather than relabeling development evidence.
- Preserve immutable rejected-release evidence and require a new corrective release; containment remains separately authorized.
- Separate technical health, automated acceptance, and explicit human acceptance. Use ordinary visible interactions, not diagnostic bypasses.
- Include UAT and UI/UX in readiness collection; remove stale six-channel coverage. Respect auto-delivered reports and require receipts for message-delivery claims.
- Keep existing readiness race guards, PR reuse, latest exact-head CI, and self-reference avoidance in their reference rather than duplicating the long AeroSim synchronization procedure.
## Runtime drift reviewed
Installed Releases `SKILL.md` SHA-256: `feac09e2515486abc35a5b127525ec3a13ca97d47f12b32cf68e434c50df9ece`. Its **Post-Approval and Deployment Evidence**, **Production Rejection and Replacement**, and **Release Completion Gate** add the acceptance and rejected-release lessons above. These are supplementary local snapshot evidence, not text attributed to the pinned source SHA. Runtime is not uniformly newer: its deployment repository wording and Gate 1 omit safeguards present in the Git source; those regressions are excluded. Hard-coded app-of-apps identities, flight-specific dwell instructions, standing merge authority, and Copier environment repair are not transplanted.
## Exclusions
No project rollout, runtime overwrite, owner reassignment, branch naming change, Jira mandate, standing merge/deploy delegation, account recovery, board/channel IDs, endpoint, scheduler cadence, or deployment configuration is promoted. Central authority and project overlays remain unchanged. The newer central functional-non-unit versus build-time artifact-validation split is retained; runtime references that send Helm artifact validation to UAT are stale and are not imported.
## Verification
Run `python3 -B -m unittest discover -s tests -v` from this repository, plus `git diff --check`. Tests validate the published documentation contract and links offline; they do not prove a deployment or live acceptance run.
+4 -4
View File
@@ -1,13 +1,13 @@
# Recurring release-readiness PR refresh
Use this procedure when an existing release-readiness PR consolidates mutable evidence from Scope, Architecture, Kanban, Delivery, or another readiness source. It prevents a successful update from publishing evidence that was already stale when committed.
Use this procedure when an existing release-readiness PR consolidates mutable evidence from Scope, Architecture, UI/UX, Kanban, Delivery, UAT, or another readiness source. It prevents a successful update from publishing evidence that was already stale when committed.
## 1. Discover rather than hard-code
1. Read new activity from all six allowed project channels and enough Releases history to identify the last reported evidence window. Use a stored or artifact-derived high-watermark and paginate until that boundary is reached; a fixed latest-N sample can be filled by recurring bot reports and cannot prove that no human release request or approval occurred. Record author type and distinguish human authorization from bot summaries.
1. Read new activity from all eight allowed project channels and enough Releases history to identify the last reported evidence window. Use a stored or artifact-derived high-watermark and paginate until that boundary is reached; a fixed latest-N sample can be filled by recurring bot reports and cannot prove that no human release request or approval occurred. Record author type and distinguish human authorization from bot summaries.
- If no separate synchronization-state file exists, derive each channel's boundary from the last verified releases report or from the readiness artifact's channel evidence links. Do not use one global timestamp when exact per-channel message IDs are available.
- Keep authorization coverage separate from display truncation. A collector may emit only the newest few messages for review, but its human-message count, newest-message ID, and high-watermark-reached assertion must be computed over **every fetched page**, not only the shortened digest. Record per channel: fetched oldest/newest IDs, boundary ID, whether the boundary was reached, and every human-authored message since that boundary. Refuse to claim that no human request or approval exists when any channel has not reached its verified boundary.
- Treat a helper that only prints the newest messages as a display digest, not an authorization collector. Before relying on an existing helper, inspect its channel map and output contract: it must include General, Scope, Architecture, Kanban, Delivery, and Releases and must emit the boundary/coverage fields above. Replace or parameterize helpers that hard-code one run's PR numbers, SHAs, task IDs, or message IDs.
- Treat a helper that only prints the newest messages as a display digest, not an authorization collector. Before relying on an existing helper, inspect its channel map and output contract: it must include General, Scope, Architecture, UI/UX, Kanban, Delivery, UAT, and Releases and must emit the boundary/coverage fields above. Replace or parameterize helpers that hard-code one run's PR numbers, SHAs, task IDs, or message IDs.
2. Discover the readiness PR by purpose, changed artifact, and source branch—not by title alone.
- If it is open and owns the same readiness page and purpose, fetch its exact remote source ref, fast-forward the clean worktree to that head, and refresh it in place.
- If it is closed or merged, preserve it as historical evidence and create a successor branch from the freshly fetched default branch. Never revive or append commits to the old review branch merely because that ref still exists remotely.
@@ -47,7 +47,7 @@ A passing build does not satisfy this guard. The guard is about evidence freshne
4. Read the artifact back through the authenticated raw API at the exact pushed SHA.
5. Assert programmatically that every required current marker is present and every superseded marker is absent.
6. Re-read the PR and task list once more immediately before reporting; retries can create a newer task for the same SHA.
7. Re-scan all six allowed channels before the final report so a newly posted human release request or approval is not missed while CI was running.
7. Re-scan all eight allowed channels before the final report so a newly posted human release request or approval is not missed while CI was running.
## 5. Report the gate accurately