refactor: simplify Delivery through existing procedure owners
This commit is contained in:
1 parent
225ae3b068
commit
de2e201c4e
8 files changed
+148
-125
No files matched your search
@@ -1,7 +1,7 @@
|
||||
---
|
||||
name: channel-delivery-skic
|
||||
description: "Use when operating or synchronizing a Corp v1 project's delivery channel. Drives coding, unit testing, build and continuous-integration health, attempts safe evidence-based fixes, escalates requirement or architecture contradictions, and maintains Ways of Working and Engineering documentation."
|
||||
version: 1.14.1
|
||||
version: 1.14.2
|
||||
author: Hermes Agent
|
||||
license: MIT
|
||||
metadata:
|
||||
@@ -20,27 +20,7 @@ Whenever a response mentions a Hermes Kanban board, initiative, card, or task, i
|
||||
|
||||
## Canonical Scope Status Vocabulary
|
||||
|
||||
Before reporting or changing any lifecycle status, read the project's current Ways of Working Scope page. Use only the canonical values defined there.
|
||||
|
||||
Ideas, Epics, and Features:
|
||||
|
||||
```text
|
||||
IN_BACKLOG → IN_DESIGN → READY_FOR_DELIVERY → IN_DELIVERY → TO_BE_RELEASED → DONE
|
||||
```
|
||||
|
||||
Tasks:
|
||||
|
||||
```text
|
||||
IN_BACKLOG → READY_FOR_DELIVERY → IN_PROGRESS → TO_BE_RELEASED → DONE
|
||||
```
|
||||
|
||||
`READY_FOR_DELIVERY` is the exact Task's Focus-admitted, pickup-ready state. It means Architecture, dependencies, implementation boundaries, verification steps, and Kanban selection are complete; implementation has not started. Delivery claims that Task by moving it directly to `IN_PROGRESS`. Never require or invent a second Focus-admission decision after `READY_FOR_DELIVERY`.
|
||||
|
||||
`CANCELLED` is an exceptional terminal status. `BLOCKED` is a separate flag with a reason and evidence; it never replaces the lifecycle status.
|
||||
|
||||
Never invent, abbreviate, or substitute lifecycle values such as `Ready`, `Active`, `Delivered`, `Complete`, `Awaiting CI`, or `Overrun`. Those phrases may describe activity only when clearly separated from the canonical status field. If the canonical status cannot be verified, report `status unverified` and inspect the source record rather than guessing.
|
||||
|
||||
A merge or successful CI does not automatically mean `DONE`. Releasable application Tasks normally move from `IN_PROGRESS` to `TO_BE_RELEASED`; `DONE` requires the applicable release or completion evidence. Status reports must show the exact canonical value even when a separate plain-language action is also included.
|
||||
Before reporting or changing lifecycle status, load [status-and-reporting.md](references/status-and-reporting.md) and read the project's current Ways of Working Scope page. That contract retains the complete canonical vocabulary, requested wave format and gate codes; `development-integrity` owns checkpoint claims. Delivery claims only an exact `READY_FOR_DELIVERY` Task into `IN_PROGRESS`, without a second Focus admission. `BLOCKED` remains a separate flag; merge/green CI is not `DONE`, and releasable application work normally ends Delivery at `TO_BE_RELEASED`.
|
||||
|
||||
This skill owns delivery health for a Corp v1 project. It monitors the project's `general`, `scope`, `architecture`, `ui-ux`, `kanban`, `delivery`, `uat`, and `releases` channels and implements only tasks whose parent Feature has explicit human `Approved for Implementation` evidence and whose exact Task status is `READY_FOR_DELIVERY`. That status is the Focus-admitted pickup handoff; no separate post-status admission gate exists.
|
||||
|
||||
@@ -54,14 +34,7 @@ Load the global `corp-v1-glossary` skill from `https://gitea.lego-cloud.eu/home-
|
||||
|
||||
## Shared Corp v1 System Login
|
||||
|
||||
When an authorized task requires login to a Corp v1 system being built or operated, follow the shared policy in `channel-board-skic` and use only the Bitwarden-injected runtime secrets named:
|
||||
|
||||
```text
|
||||
HL_V1_SSO_EMAIL
|
||||
HL_V1_SSO_PASSWORD
|
||||
```
|
||||
|
||||
Secret availability is capability, not authorization. Verify the destination origin and task purpose before login. Never print, inspect, log, hash, serialize, paste, screenshot, or persist either value; never place a value in a command line, URL, file, repository, prompt, Discord message, browser console, test fixture, CI output, or generated artifact. Never ask a human to paste a value into chat. If a variable is unavailable, report only its missing name and request Bitwarden/gateway injection. Login does not authorize account recovery, MFA or credential changes, permission changes, billing, spending, destructive operations, or access outside the approved project task.
|
||||
Before login, load `channel-board-skic` from [its authoritative source](https://gitea.lego-cloud.eu/skic-skills/channel-board-skic) and follow **Corp v1 System SSO Credential Use** in full. It owns origin/purpose verification, runtime-only `HL_V1_SSO_EMAIL` / `HL_V1_SSO_PASSWORD` handling, non-disclosure, missing-secret injection and session safety. If that policy cannot be loaded, stop before login. Secret availability is not authorization; Delivery grants no account recovery, credential/MFA, permission, billing, destructive-operation or unrelated-access authority.
|
||||
|
||||
## When to Use
|
||||
|
||||
@@ -153,16 +126,7 @@ Delivery still monitors repository-specific compile/type, unit-test, lint/format
|
||||
|
||||
### Per-project reusable CI base images
|
||||
|
||||
Each Corp v1 project should own `corp-v1-<code>/corp-v1-<code>-base-images` when stable runtimes or operating-system tools would otherwise be downloaded repeatedly in application CI.
|
||||
|
||||
- Keep one folder per image, with its Dockerfile, machine-readable version/platform metadata, usage documentation, build helper, and static publication contract. Runtime smoke belongs to UAT.
|
||||
- Pin the upstream base by digest and assert exact runtime/tool versions, architecture, numeric non-root identity, writable workspace, CA trust, Git, shell, and other required tools.
|
||||
- Build and perform static/unit validation without registry credentials on pull requests. Publish only from the trusted integration branch using a narrowly scoped Harbor robot secret; UAT validates the published digest at runtime.
|
||||
- Publish immutable full-source-SHA tags, read back the Harbor artifact digest, and consume the image from project workflows by digest—not `latest`, a mutable version tag, or an unverified local name.
|
||||
- Extend fail-closed tests to reject broad publication triggers, mutable tags, secret access from candidate/PR paths, shell interpolation, wrong digests, and reintroduced runtime setup actions.
|
||||
- Prefer the verified job image over repeated runtime or package-manager setup actions. Keep lockfile-frozen application dependency installation in the application repository; do not bake project dependencies into a generic base image.
|
||||
- Treat the first real Gitea build, Harbor publication, digest readback, and consumer workflow at the exact candidate SHA as separate Delivery layers. Runtime smoke is a separate UAT layer.
|
||||
- Repair image or publication failures forward only. Preserve the last known-good digest for consumers until the replacement image and consuming workflow pass exact-head CI.
|
||||
Each project should own `corp-v1-<code>/corp-v1-<code>-base-images` when stable runtimes or OS tools would otherwise be downloaded repeatedly in CI. Before creating, publishing or consuming an image, load [the complete Delivery-owned base-image contract](references/runtime-and-ci.md#per-project-reusable-ci-base-images). It retains digest pinning, credential-free candidate validation, trusted integration-branch publication, immutable tags/digest readback, fail-closed tests and forward repair with the last known-good digest. Runtime smoke remains UAT-owned; no external CI owner is assumed to replace this contract.
|
||||
|
||||
### Runtime-resource placement
|
||||
|
||||
@@ -176,49 +140,11 @@ CI jobs and developer workstations must not provision databases, queues, object
|
||||
|
||||
## Failure-Repair Workflow
|
||||
|
||||
When a build or CI failure is observed:
|
||||
|
||||
1. verify repository, branch, head SHA, failed job, and exact logs;
|
||||
2. reproduce locally when feasible;
|
||||
3. determine root cause before editing;
|
||||
4. compare the intended fix against approved FR/NFRs, ADRs, architecture documentation, and project conventions;
|
||||
5. implement the smallest safe fix;
|
||||
6. add/update tests where behavior changed;
|
||||
7. run local validation;
|
||||
8. commit and push through the approved branch workflow;
|
||||
9. inspect CI for the exact new head SHA;
|
||||
10. report evidence and remaining risk.
|
||||
|
||||
The skill may attempt a safe fix when the failure and expected behavior are clear. If evidence is insufficient or requirements/architecture conflict, stop and raise the issue in the relevant channel:
|
||||
|
||||
- requirement/product ambiguity → `general` and/or `architecture` as appropriate;
|
||||
- architecture contradiction → `architecture`;
|
||||
- release policy/readiness ambiguity → `releases`;
|
||||
- implementation-only blocker → `delivery`.
|
||||
|
||||
Never guess the team's intended direction.
|
||||
Load [failure-and-documentation.md](references/failure-and-documentation.md#failure-repair-workflow) when a build or CI failure is observed. It owns diagnosis, safe forward repair, affected validation, exact-head CI and escalation destinations. Keep repairable failures in the same Task/gate; pause only for the documented external, authority, decision or safety blocker. Never guess requirements or Architecture, weaken a gate or treat a blocker as passing.
|
||||
|
||||
## Documentation Ownership
|
||||
|
||||
Maintain two documentation areas.
|
||||
|
||||
### Ways of Working — five sections
|
||||
|
||||
1. **Delivery workflow** — intake, prioritization, implementation states, and definition of done.
|
||||
2. **Branching and reviews** — branch conventions, pull requests, approvals, and merge expectations.
|
||||
3. **Planning and ownership** — backlog, sequencing, owners, dependencies, blockers, and escalation.
|
||||
4. **Quality practices** — review standards, test strategy, defect handling, and evidence expectations.
|
||||
5. **Collaboration and decisions** — channel routing, handoffs, decision references, and communication norms.
|
||||
|
||||
### Engineering — five sections
|
||||
|
||||
1. **Repository and workspace** — monorepo/application/package structure and local prerequisites.
|
||||
2. **Development and unit testing** — commands, unit-test fixtures, debugging, Delivery artifact validation, and the handoff to UAT for every functional non-unit suite.
|
||||
3. **Build and continuous integration** — pipelines, checks, artifacts, runners, and failure diagnosis.
|
||||
4. **Packaging and deployment preparation** — containers, Helm/GitOps interfaces, configuration, and release inputs.
|
||||
5. **Operations and troubleshooting** — observability, known failure modes, recovery checks, and evidence collection.
|
||||
|
||||
Update these pages from verified project practice. Do not document a planned process as already operational.
|
||||
Delivery owns verified Ways of Working and Engineering content, not documentation-platform mechanics. Before changing either area, load [the domain coverage contract](references/failure-and-documentation.md#documentation-ownership), the linked global `documentation-docusaurus` source and the project-adopted documentation overlay. Load `corp-v1-glossary` before defining reusable terms. Keep planned practice distinct from operational evidence.
|
||||
|
||||
## UI/UX Coordination
|
||||
|
||||
@@ -289,17 +215,7 @@ When selectable controls are needed, explain every complete option and its trade
|
||||
|
||||
## Common Pitfalls
|
||||
|
||||
1. Patching symptoms before understanding root cause.
|
||||
2. Changing requirements or architecture implicitly through code.
|
||||
3. Claiming CI success from a local build.
|
||||
4. Editing without loading applicable project engineering skills.
|
||||
5. Skipping tests for behavioral fixes.
|
||||
6. Updating documentation with aspirational rather than actual practice.
|
||||
7. Repeatedly posting unchanged failure summaries.
|
||||
8. Inspecting another project.
|
||||
9. Starting implementation because requirements exist but human implementation approval is absent.
|
||||
10. Ignoring architecture task dependencies, Kanban Focus admission, or target-version allocation.
|
||||
11. Posting passive status when safe implementation, testing, diagnosis, or documentation work is available.
|
||||
Load [common-pitfalls.md](references/common-pitfalls.md) on failed gates, resumed work and before blocker/CI/merge/completion reports. It retains the complete Delivery traps, including approval/admission, same-project scope, useful safe activity, real evidence and same-gate forward repair. These reminders do not replace the ordered Task gates.
|
||||
|
||||
## Verification Checklist
|
||||
|
||||
|
||||
Reference in new issue
Block a user