From 2e7f6618b6bf47fe983f75ef41ca83352074ee84 Mon Sep 17 00:00:00 2001 From: Jarvis Jr Hermes Date: Mon, 26 Oct 2026 10:17:40 +0000 Subject: [PATCH 1/3] chore: open scoped Delivery source correction From 9d1a6dd44d6c4eff3eb495be8f04ea169beaf0b3 Mon Sep 17 00:00:00 2001 From: Jarvis Jr Hermes Date: Mon, 26 Oct 2026 10:22:35 +0000 Subject: [PATCH 2/3] fix: qualify Delivery sources and preserve compatibility --- SKILL.md | 8 ++++++-- references/failure-and-documentation.md | 2 +- references/planning-artifact-reconciliation.md | 2 +- tests/disposition-dependencies.json | 6 ++++-- tests/disposition-protected.json | 2 +- tests/test_disposition_contract.py | 5 +++-- tests/test_draft_routing.py | 8 ++++++++ 7 files changed, 24 insertions(+), 9 deletions(-) create mode 100644 tests/test_draft_routing.py diff --git a/SKILL.md b/SKILL.md index 9163612..1a3d0d5 100644 --- a/SKILL.md +++ b/SKILL.md @@ -1,13 +1,13 @@ --- name: channel-delivery-skic description: "Use when operating or synchronizing a Corp v1 project's delivery channel. Drives coding, unit testing, build and continuous-integration health, attempts safe evidence-based fixes, escalates requirement or architecture contradictions, and maintains Ways of Working and Engineering documentation." -version: 1.16.0 +version: 1.17.0 author: Hermes Agent license: MIT metadata: hermes: tags: [corp-v1, discord, channel, delivery, coding, testing, ci] - related_skills: [channel-board-skic, discord, documentation-docusaurus, glossary-skic, development-durable-wave-execution, development-gates, development-integrity, development-method-ttd, development-branching-strategy, development-monorepo-pnpm, development-scripts, development-gitops-argo-cd-home-gondor-v1, ci-runtime-skic, delivery-docs, status-reporting-skic, development-security, development-security-skic] + related_skills: [channel-board-skic, discord, documentation-docusaurus-global, glossary-skic, development-durable-wave-execution, development-gates, development-integrity, development-method-ttd, development-branching-strategy, development-monorepo-pnpm, development-scripts, development-gitops-argo-cd-home-gondor-v1, ci-runtime-skic, delivery-docs, status-reporting-skic, development-security, development-security-skic, develop-monorepo-pnpm-app-skic, develop-monorepo-pnpm-package-skic] --- # SKIC Delivery Channel Reference @@ -32,6 +32,10 @@ Before branch or script work, load the generic `development-branching-strategy` ## Development Skill Routing +Before changing an application's configuration, startup/readiness/shutdown contract or integration boundaries, load `develop-monorepo-pnpm-app-skic`. Before changing a shared package's public API/exports, dependency boundary, version compatibility or published contents, load `develop-monorepo-pnpm-package-skic`. For a change crossing both boundaries, load both and identify producer/consumer responsibilities; do not infer impact solely from a directory name. + +These are **draft review aids, not approved standards**. Contributor input and project adoption approval are separate from source publication or this routing. Use them to identify questions and evidence against the Task's already approved contract; do not enforce a proposed convention without the relevant human owner's approval. They complement `development-monorepo-pnpm`, which continues to own workspace/build/package-manager mechanics. Review, CI, one implementation worker per Task, deployment and test-ownership gates remain unchanged; loading a draft grants no execution authority. Authoritative drafts: https://gitea.lego-cloud.eu/skic-skills/develop-monorepo-pnpm-app-skic and https://gitea.lego-cloud.eu/skic-skills/develop-monorepo-pnpm-package-skic. + Before CI/runtime/repair work load `ci-runtime-skic`; before status/blocker reports load `status-reporting-skic`; before documentation load `delivery-docs`; before authenticated operations load `development-security-skic` and `development-security`. Supply the concrete bindings in the matching local reference. Authoritative helper repositories: https://gitea.lego-cloud.eu/skic-skills/ci-runtime-skic, https://gitea.lego-cloud.eu/global-skills/delivery-docs, https://gitea.lego-cloud.eu/skic-skills/status-reporting-skic, https://gitea.lego-cloud.eu/global-skills/development-security and https://gitea.lego-cloud.eu/skic-skills/development-security-skic. This channel skill owns **delivery governance and project-channel coordination**. Reusable engineering procedures belong to the global `development-*` skills below; load the matching skill before the action and treat a project-adopted variant as the project-specific overlay when one exists. diff --git a/references/failure-and-documentation.md b/references/failure-and-documentation.md index 3d19479..b49001c 100644 --- a/references/failure-and-documentation.md +++ b/references/failure-and-documentation.md @@ -6,7 +6,7 @@ Before diagnosis or forward repair, load `ci-runtime-skic` for the same-gate rep ## Documentation Ownership -Before changing Delivery-owned Ways of Working or Engineering, load `delivery-docs` for coverage and evidence-to-page reconciliation. Bind the authoring owner to `documentation-docusaurus` at https://gitea.lego-cloud.eu/home-v1-skills-code-agent/documentation-docusaurus, plus the project-adopted overlay. Before defining reusable terms, bind/load `glossary-skic` at https://gitea.lego-cloud.eu/home-v1-skills-code-agent/glossary-skic. Stop if the source-qualified owner is unavailable; an unrelated same-name runtime skill is not that owner. +Before changing Delivery-owned Ways of Working or Engineering, load `delivery-docs` for coverage and evidence-to-page reconciliation. Bind the authoring owner to `documentation-docusaurus-global` at https://gitea.lego-cloud.eu/home-v1-skills-code-agent/documentation-docusaurus, plus the project-adopted overlay. Before defining reusable terms, bind/load `glossary-skic` at https://gitea.lego-cloud.eu/home-v1-skills-code-agent/glossary-skic. Stop if the source-qualified owner is unavailable; an unrelated same-name runtime skill is not that owner. ## Synchronization Workflow diff --git a/references/planning-artifact-reconciliation.md b/references/planning-artifact-reconciliation.md index 9f746ff..64ed31a 100644 --- a/references/planning-artifact-reconciliation.md +++ b/references/planning-artifact-reconciliation.md @@ -8,7 +8,7 @@ Before verifying a PR or CI, run `skill_view(name="development-gates")` and load Before reporting, load `skill_view(name="development-integrity")` and its `references/remote-checkpoint-matrix.md` for the current remote checkpoint, changed-head invalidation and candidate-versus-integration claims; then load [status-and-reporting.md](status-and-reporting.md) for Delivery formatting. Preserve project reviewer/merge authority; A02/A04 review-order/base-drift remain bounded unresolved clauses, not implicitly settled by these loads. -Before validation, load `documentation-docusaurus` and the project-adopted overlay through [Documentation Ownership](failure-and-documentation.md#documentation-ownership); verify source identity. Run the complete repository validator and production build with frozen-lockfile installation and `git diff --check`. The global owner identity mismatch remains unresolved: retain the bounded nested-pnpm fallback below, not an assumed replacement owner. +Before validation, load `documentation-docusaurus-global` and the project-adopted overlay through [Documentation Ownership](failure-and-documentation.md#documentation-ownership); verify source identity. Run the complete repository validator and production build with frozen-lockfile installation and `git diff --check`. Generic and VSSA packages now have separate source-qualified names. Retain the bounded nested-pnpm fallback below until that procedure is present in the generic owner; identity repair alone does not establish procedural coverage. If child scripts cannot find pnpm, use `corepack enable --install-directory /pnpm-bin`, prepend that temporary shim directory to `PATH`, and rerun the declared command. Keep shim/dependency caches outside commits and verify the worktree remains clean. diff --git a/tests/disposition-dependencies.json b/tests/disposition-dependencies.json index 8d375f6..9cfc7a6 100644 --- a/tests/disposition-dependencies.json +++ b/tests/disposition-dependencies.json @@ -2,7 +2,7 @@ "retained": [ "channel-board-skic", "discord", - "documentation-docusaurus", + "documentation-docusaurus-global", "glossary-skic", "development-durable-wave-execution", "development-gates", @@ -18,6 +18,8 @@ "delivery-docs", "status-reporting-skic", "development-security", - "development-security-skic" + "development-security-skic", + "develop-monorepo-pnpm-app-skic", + "develop-monorepo-pnpm-package-skic" ] } diff --git a/tests/disposition-protected.json b/tests/disposition-protected.json index a473360..c95f024 100644 --- a/tests/disposition-protected.json +++ b/tests/disposition-protected.json @@ -9,7 +9,7 @@ }, { "path": "references/planning-artifact-reconciliation.md", - "sha256": "98e64da5093db3e2c18c84a54993d1413e59a42f86788504ed63117ff069392f" + "sha256": "098c16b5f2f5d7a55211cefcc31bdfd8daaffad8433f0a32b34e8bdf0da0c611" }, { "path": "references/aerosim-lessons-review.md", diff --git a/tests/test_disposition_contract.py b/tests/test_disposition_contract.py index 58a2434..d530659 100644 --- a/tests/test_disposition_contract.py +++ b/tests/test_disposition_contract.py @@ -17,7 +17,8 @@ class Disposition(unittest.TestCase): t=(ROOT/'SKILL.md').read_text(); d=json.loads((TESTS/'disposition-dependencies.json').read_text()) actual=re.search(r'related_skills: \[(.*?)\]',t).group(1).split(', ') self.assertEqual(actual,d['retained']+d['additional']); self.assertEqual(len(actual),len(set(actual))) - self.assertNotIn('develop-monorepo-pnpm-app-skic',actual); self.assertNotIn('develop-monorepo-pnpm-package-skic',actual) + self.assertIn('develop-monorepo-pnpm-app-skic',actual); self.assertIn('develop-monorepo-pnpm-package-skic',actual) + self.assertIn('draft review aids, not approved standards',t) for n in d['additional']: self.assertIn('`'+n+'`',t) for n in ['gitops-manifest-engineering','gondor-v1-nodes']: @@ -54,7 +55,7 @@ class Disposition(unittest.TestCase): self.assertIn(s,docs) self.assertNotIn('### Ways of Working',local);self.assertIn('delivery-docs',local) self.assertIn('glossary-skic',local) - self.assertIn('documentation-docusaurus-skic-aerosim' if ROOT.name.endswith('aerosim') else 'documentation-docusaurus',local) + self.assertIn('documentation-docusaurus-skic-aerosim' if ROOT.name.endswith('aerosim') else 'documentation-docusaurus-global',local) def test_security_preserves_single_policy_owner(self): security=owner('development-security-skic'); generic=owner('development-security') for s in ['channel-board-skic','Corp v1 System SSO Credential Use','Stop before login','development-security','Central Delivery gains no self-recovery authority']: diff --git a/tests/test_draft_routing.py b/tests/test_draft_routing.py new file mode 100644 index 0000000..c2a029c --- /dev/null +++ b/tests/test_draft_routing.py @@ -0,0 +1,8 @@ +from pathlib import Path +import unittest +class DraftRouting(unittest.TestCase): + def test_scoped_draft_decision_points(self): + text=(Path(__file__).resolve().parents[1]/'SKILL.md').read_text() + for marker in ['startup/readiness/shutdown','public API/exports','develop-monorepo-pnpm-app-skic','develop-monorepo-pnpm-package-skic','draft review aids, not approved standards','do not enforce a proposed convention','one implementation worker per Task','loading a draft grants no execution authority','workspace/build/package-manager mechanics']: + self.assertIn(marker,text) +if __name__=='__main__':unittest.main() From 0776bacd25dec4edf5047cf035555cb0891966d4 Mon Sep 17 00:00:00 2001 From: Jarvis Jr Hermes Date: Mon, 26 Oct 2026 10:24:59 +0000 Subject: [PATCH 3/3] test: align expected version with source identity release --- tests/test_aerosim_lessons_contract.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_aerosim_lessons_contract.py b/tests/test_aerosim_lessons_contract.py index b8721de..e9269f1 100644 --- a/tests/test_aerosim_lessons_contract.py +++ b/tests/test_aerosim_lessons_contract.py @@ -39,7 +39,7 @@ class LessonsContract(unittest.TestCase): def test_contract_1(self): text = (ROOT / 'SKILL.md').read_text() self.assertIn('-uat', text) - self.assertIn('version: 1.16.0', text) + self.assertIn('version: 1.17.0', text) def test_stage_five_scope_and_authority(self): text = (ROOT / "references/task-delivery-gates.md").read_text()